Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39573: Update clinic to use Py_IS_TYPE macro #18507

Merged
merged 2 commits into from Feb 14, 2020
Merged

bpo-39573: Update clinic to use Py_IS_TYPE macro #18507

merged 2 commits into from Feb 14, 2020

Conversation

@corona10
Copy link
Member

corona10 commented Feb 14, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39573
@corona10 corona10 requested a review from vstinner Feb 14, 2020
@corona10
bpo-39573: Update clinic to use Py_IS_TYPE macro
Loading status checks…
25dc827
@corona10 corona10 force-pushed the corona10:bpo-39573-clinic branch from b531904 to 25dc827 Feb 14, 2020
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Feb 14, 2020 •
edited

Codecov Report

Merging #18507 into master will increase coverage by 2.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18507       +/-   ##
===========================================
+ Coverage   79.46%   82.12%    +2.65%     
===========================================
  Files         384     1955     +1571     
  Lines      169290   583979   +414689     
  Branches        0    44450    +44450     
===========================================
+ Hits       134529   479572   +345043     
- Misses      34761    94765    +60004     
- Partials        0     9642     +9642
Impacted Files Coverage Δ
Programs/_testembed.c 89.43% <0.00%> (-0.13%) ⬇️
Lib/test/test_reprlib.py 95.75% <0.00%> (ø)
Lib/modulefinder.py 67.44% <0.00%> (ø)
Lib/distutils/tests/support.py 85.00% <0.00%> (ø)
Lib/email/mime/base.py 100.00% <0.00%> (ø)
Lib/tkinter/test/test_ttk/test_widgets.py 97.43% <0.00%> (ø)
Lib/importlib/abc.py 93.44% <0.00%> (ø)
Lib/test/test_property.py 90.32% <0.00%> (ø)
Lib/test/test_importlib/test_open.py 95.23% <0.00%> (ø)
Lib/unittest/test/testmock/support.py 87.50% <0.00%> (ø)
... and 1564 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f632736...79b5e0b. Read the comment docs.
@corona10
bpo-39473: Update NEWS
Loading status checks…
79b5e0b
@vstinner vstinner merged commit 9aeb0ef into python:master Feb 14, 2020
11 checks passed
11 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200214.6 succeeded
Details
bedevere/issue-number Issue number 39573 found
Details
bedevere/news News entry found in Misc/NEWS.d
codecov/patch 90.00% of diff hit (target 79.46%)
Details
codecov/project 82.12% (+2.65%) compared to f632736
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Feb 14, 2020

Merged, thanks. I just replace "macro" with "function" in the commit message :-)
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
1993d7c
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
9099952
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
c3d8881
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
5f80d11
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
8f174b9
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
2ae7689
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
4ae3953
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
f7ed1b3
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
6642699
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
2938523
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
d487d84
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
d12f34a
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
da454c1
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
4443d71
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
3daa992
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
ea16daa
petdance added a commit to petdance/cpython that referenced this pull request Feb 18, 2020
@corona10 @petdance
bpo-39573: Update clinic to use Py_IS_TYPE() function (pythonGH-18507)
e40c174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.