New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39663: IDLE: Add additional tests for pyparse #18536

Merged

terryjreedy merged 4 commits into python:master from csabella:parse

Feb 18, 2020

Contributor

csabella commented Feb 17, 2020 •

edited by bedevere-bot

Add test cases when find_good_parse_start would return 0 instead of None.

https://bugs.python.org/issue39663


        bpo-39663: IDLE: Add additional tests for pyparse

ae7a74e

csabella requested a review from terryjreedy as a code owner

the-knights-who-say-ni added the CLA signed label

bedevere-bot added type-tests awaiting core review labels

Contributor Author

csabella commented Feb 17, 2020

Test failure is unrelated to this change.

python deleted a comment from codecov bot

terryjreedy reviewed

Member

terryjreedy left a comment

Looks good. I will factor out "is_char_in_string=lambda index: False" and add news items and when CI passes, merge and backport.

terryjreedy added needs backport to 3.7 needs backport to 3.8 labels

terryjreedy added 3 commits


        Merge remote-tracking branch 'origin/master' into pr_18536

759ff40


        Add news item.

cc94acf


        Factor out function.

17c170e

terryjreedy merged commit ffda25f into python:master

8 of 9 checks passed

8 of 9 checks passed

Docs

Details

Windows (x86)

Details

Windows (x64)

Details

macOS macOS

Details

Ubuntu

Details

Azure Pipelines PR #20200218.2 succeeded with issues

Details

bedevere/issue-number Issue number 39663 found

Details

bedevere/news News entry found in Misc/NEWS.d

continuous-integration/travis-ci/pr The Travis CI build passed

Details

miss-islington commented Feb 18, 2020

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot removed the awaiting core review label

miss-islington commented Feb 18, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington added a commit to miss-islington/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

acda9dc

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ffda25f)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

bedevere-bot commented Feb 18, 2020

GH-18541 is a backport of this pull request to the 3.7 branch.

bedevere-bot removed the needs backport to 3.7 label

terryjreedy added needs backport to 3.8 and removed needs backport to 3.8 labels

miss-islington commented Feb 18, 2020

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot commented Feb 18, 2020

GH-18542 is a backport of this pull request to the 3.8 branch.

bedevere-bot removed the needs backport to 3.8 label

Member

terryjreedy commented Feb 18, 2020

The unrelated macOS failure occurred again, but success seems to not currently be required.

miss-islington added a commit that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (GH-18536)

fde0041

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ffda25f)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

miss-islington added a commit that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (GH-18536)

7fd752c

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ffda25f)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

d8558ee

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

e855530

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

423fd17

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

9f8e72a

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

a42354f

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

560e045

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

9ca9713

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

9802e4d

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

2aa95a3

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

287f0b5

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

1916e75

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

3342b23

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

2f89ab1

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

54499d4

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

26ea8ee

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

d209682

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

3a62823

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

002a116

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

petdance added a commit to petdance/cpython that referenced this pull request


        bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)

c9dcbb0

Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.