bpo-35950: Raise UnsupportedOperation in BufferedReader.truncate() #18586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Feb 21, 2020
Modules/_io/bufferedio.c
Outdated
| if (!self->writable) { | ||
| LEAVE_BUFFERED(self) | ||
| return bufferediobase_unsupported("truncate"); | ||
| } |
There was a problem hiding this comment.
Can we move this code block before If (!ENTER_BUFFERED(self))?
The truncate() method of io.BufferedReader() should raise UnsupportedOperation when it is called on a read-only io.BufferedReader() instance.
berkerpeksag
force-pushed
the
bpo-35950-truncate-read-only-v2
branch
from
07ea7d9 to
5e4f7f6
Compare
methane
approved these changes
Feb 21, 2020
|
@berkerpeksag: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The truncate() method of io.BufferedReader() should raise
UnsupportedOperation when it is called on a read-only
io.BufferedReader() instance.
https://bugs.python.org/issue35950
Automerge-Triggered-By: @methane