Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: macos - change "versiona" to "versions" #18467

Merged
merged 1 commit into from Feb 12, 2020
Merged

docs: macos - change "versiona" to "versions" #18467

merged 1 commit into from Feb 12, 2020

Conversation

@RandyMcMillan
Copy link
Contributor

RandyMcMillan commented Feb 12, 2020

No description provided.

@RandyMcMillan
docs: macos - change "versiona" to "versions"
Verified
This commit was signed with a verified signature.
RandyMcMillan @RandyMcMillan
GPG key ID: 97966C06BB06757B Learn about signing commits
Loading status checks…
e8f2641
@RandyMcMillan RandyMcMillan requested a review from python/macos-team as a code owner Feb 12, 2020
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Feb 12, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@RandyMcMillan

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@brandtbucher brandtbucher removed the request for review from python/macos-team Feb 12, 2020
@brandtbucher

This comment has been minimized.

Sign in to view
Copy link
Member

brandtbucher commented Feb 12, 2020

Thanks for your time @RandyMcMillan, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?
@brandtbucher
brandtbucher approved these changes Feb 12, 2020
View changes
Copy link
Member

brandtbucher left a comment

This looks good, thanks!
@ned-deily ned-deily merged commit 029e840 into python:master Feb 12, 2020
4 checks passed
4 checks passed
Azure Pipelines PR #20200212.2 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 12, 2020

Thanks @RandyMcMillan for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 12, 2020

GH-18469 is a backport of this pull request to the 3.8 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 12, 2020

GH-18470 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @miss-islington
docs: macos - change "versiona" to "versions" (pythonGH-18467)
629ce20 
(cherry picked from commit 029e840)

Co-authored-by: @RandyMcMillan <randy.lee.mcmillan@gmail.com>
@ned-deily

This comment has been minimized.

Sign in to view
Copy link
Member

ned-deily commented Feb 12, 2020

Thanks for the PR! Please be sure to fill out the contributor agreement.
@brandtbucher

This comment has been minimized.

Sign in to view
Copy link
Member

brandtbucher commented Feb 12, 2020

@ned-deily do we ignore the CLA check for trivial fixes like this?
@brandtbucher

This comment has been minimized.

Sign in to view
Copy link
Member

brandtbucher commented Feb 12, 2020

I see we crossed posts.
ned-deily pushed a commit that referenced this pull request Feb 12, 2020
@miss-islington @RandyMcMillan
docs: macos - change "versiona" to "versions" (GH-18467) (GH-18469)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0f0d2e4 
(cherry picked from commit 029e840)

Co-authored-by: @RandyMcMillan <randy.lee.mcmillan@gmail.com>
ned-deily pushed a commit that referenced this pull request Feb 12, 2020
@miss-islington @RandyMcMillan
docs: macos - change "versiona" to "versions" (GH-18467) (GH-18470)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a933f74 
(cherry picked from commit 029e840)

Co-authored-by: @RandyMcMillan <randy.lee.mcmillan@gmail.com>
opavlyuk pushed a commit to opavlyuk/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan opavliuk
docs: macos - change "versiona" to "versions" (pythonGH-18467)
c0dc49c
vstinner added a commit to vstinner/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @vstinner
docs: macos - change "versiona" to "versions" (pythonGH-18467)
ddc4dfb
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
d34e645
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
baa1e92
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
692cb57
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
bba4ea4
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
8ec9cbe
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
6de0930
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
78f1184
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
870e706
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
d367f6b
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
7c0befe
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
c118805
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
ddf1322
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
f648986
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
082b092
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
190e9a6
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
@RandyMcMillan @petdance
docs: macos - change "versiona" to "versions" (pythonGH-18467)
cb7e581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher

Assignees
No one assigned
Labels
CLA not signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@RandyMcMillan @the-knights-who-say-ni @brandtbucher @miss-islington @bedevere-bot @ned-deily
You can’t perform that action at this time.