bpo-39674: Suggest to test with DeprecationWarning #18552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a section in What's New In Python 3.9 to strongly advice to check for DeprecationWarning in your Python projects.
|
@brettcannon: Does it sound like what you proposed in the python-dev thread? |
hugovk
reviewed
Feb 19, 2020
Doc/whatsnew/3.9.rst
Outdated
| ==================================================== | ||
|
|
||
| When Python 2.7 was still supported, many functions were kept for backward | ||
| compatibility with Python 2.7. With the end of the Python 2.7 support, these |
There was a problem hiding this comment.
Suggested change
| compatibility with Python 2.7. With the end of the Python 2.7 support, these | |
| compatibility with Python 2.7. With the end of Python 2.7 support, these |
Doc/whatsnew/3.9.rst
Outdated
|
|
||
| When Python 2.7 was still supported, many functions were kept for backward | ||
| compatibility with Python 2.7. With the end of the Python 2.7 support, these | ||
| backward compatibility layers have been reomved or will be removed shortly. |
There was a problem hiding this comment.
Suggested change
| backward compatibility layers have been reomved or will be removed shortly. | |
| backward compatibility layers have been removed, or will be removed soon. |
Doc/whatsnew/3.9.rst
Outdated
| When Python 2.7 was still supported, many functions were kept for backward | ||
| compatibility with Python 2.7. With the end of the Python 2.7 support, these | ||
| backward compatibility layers have been reomved or will be removed shortly. | ||
| Most of them emitted :exc:`DeprecationWarning` warning for several years. For |
There was a problem hiding this comment.
Suggested change
| Most of them emitted :exc:`DeprecationWarning` warning for several years. For | |
| Most of them emitted a :exc:`DeprecationWarning` warning for several years. For |
Doc/whatsnew/3.9.rst
Outdated
| backward compatibility layers have been reomved or will be removed shortly. | ||
| Most of them emitted :exc:`DeprecationWarning` warning for several years. For | ||
| example, using ``collections.Mapping`` instead of ``collections.abc.Mapping`` | ||
| emits a :exc:`DeprecationWarning` since Python 3.3 released in 2012. |
There was a problem hiding this comment.
Suggested change
| emits a :exc:`DeprecationWarning` since Python 3.3 released in 2012. | |
| emits a :exc:`DeprecationWarning` since Python 3.3, released in 2012. |
Doc/whatsnew/3.9.rst
Outdated
| example, using ``collections.Mapping`` instead of ``collections.abc.Mapping`` | ||
| emits a :exc:`DeprecationWarning` since Python 3.3 released in 2012. | ||
|
|
||
| Test your application with :option:`-W` ``default`` command line option to see |
There was a problem hiding this comment.
Suggested change
| Test your application with :option:`-W` ``default`` command line option to see | |
| Test your application with the :option:`-W` ``default`` command-line option to see |
Doc/whatsnew/3.9.rst
Outdated
| Test your application with :option:`-W` ``default`` command line option to see | ||
| :exc:`DeprecationWarning` and :exc:`PendingDeprecationWarning`, or even with | ||
| :option:`-W` ``error`` to treat them as errors. :ref:`Warnings Filter | ||
| <warning-filter>` can be used to ignore warnings from third party code. |
There was a problem hiding this comment.
Suggested change
| <warning-filter>` can be used to ignore warnings from third party code. | |
| <warning-filter>` can be used to ignore warnings from third-party code. |
|
Yep, this is what I was thinking, but you forgot to mention |
Right. But you wrote that you wasn't convinced that the relationship between DeprecationWarning and -X dev, so I focused on warnings instead ;-) |
|
I think it's also worth mentioning |
Ok, done. |
hugovk
reviewed
Mar 3, 2020
Co-Authored-By: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
Thanks @hugovk for your useful reviews! |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add a section in What's New In Python 3.9 to strongly advice to check
for DeprecationWarning in your Python projects.
https://bugs.python.org/issue39674