Skip to content

/ incubator-airflow

forked from apache/airflow
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed orphaned/broken symlinks that are causing 'pip download' failures #22

Merged
merged 1 commit into from Feb 24, 2020
Merged

Removed orphaned/broken symlinks that are causing 'pip download' failures #22

merged 1 commit into from Feb 24, 2020

Conversation

@preston-m-price
Copy link

preston-m-price commented Feb 24, 2020

There are 2 orphaned/broken symlinks:

find . -xtype l
./airflow/www_rbac/static/docs
./airflow/www/static/docs

Both links point to the same missing destination:

# ls -al airflow/www_rbac/static/docs
lrwxrwxrwx 1 root root 26 Feb 24 19:31 airflow/www_rbac/static/docs -> ../../../docs/_build/html/
# ls -al airflow/www/static/docs
lrwxrwxrwx 1 root root 26 Feb 24 19:31 airflow/www/static/docs -> ../../../docs/_build/html/

During unpacking with pip download this causes the package download to fail because pip is trying to operations to perform and the navigation to the missing destination causes it to fail with an error:

FileNotFoundError: [Errno 2] No such file or directory: '/src/apache-airflow/airflow/www_rbac/static/docs'

It appears this is still a feature of the 1.10-stable branch for airflow
but has been resolved in 1.10-test

The broken link in www was removed 6 days ago in 1.10-test

The broken link in www_rbac was removed 8 days ago in 1.10-test
@preston-m-price
Removed orphaned/broken symlinks that are causing 'pip download' comm…
602e4f4 
…ands to fail.
@preston-m-price
Copy link
Author

preston-m-price commented Feb 24, 2020

Confirmed pip download works when referencing this branch:
-e git+ssh://git@github.com/github/incubator-airflow.git@remove-broken-links#egg="apache-airflow[crypto, devel_hadoop, postgres, slack, ssh, celery, azure_data_lake]"
@preston-m-price preston-m-price merged commit c017f16 into gh-1.10.3 Feb 24, 2020
@tbries tbries mentioned this pull request Apr 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@preston-m-price
You can’t perform that action at this time.