Skip to content

bpo-39764: Make Task.get_stack accept ag_frame #18669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2020
Merged

bpo-39764: Make Task.get_stack accept ag_frame #18669

merged 2 commits into from
Mar 2, 2020

Conversation

lidizheng
Copy link
Contributor

@lidizheng lidizheng commented Feb 26, 2020 •
edited by miss-islington
Loading

The title will be updated after the issue's creation.

https://bugs.python.org/issue39764

Automerge-Triggered-By: @asvetlov

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@lidizheng

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@lidizheng lidizheng changed the title Make Task.get_stack accept ag_frame bpo-39764: Make Task.get_stack accept ag_frame Feb 26, 2020
@lidizheng lidizheng mentioned this pull request Feb 26, 2020
Closed
@lidizheng
Copy link
Contributor Author

The test failure seems due to flake:

Timeout (0:20:00)!
Thread 0x00007f73c2100080 (most recent call first):
  File "/home/runner/work/cpython/cpython/Lib/tkinter/__init__.py", line 697 in wait_visibility
  File "/home/runner/work/cpython/cpython/Lib/tkinter/test/test_ttk/test_extensions.py", line 190 in test_resize
  File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 616 in _callTestMethod
  File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 659 in run
  File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 719 in __call__
  File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/cpython/cpython/Lib/unittest/runner.py", line 176 in run
  File "/home/runner/work/cpython/cpython/Lib/test/support/__init__.py", line 2079 in _run_suite
  File "/home/runner/work/cpython/cpython/Lib/test/support/__init__.py", line 2201 in run_unittest
  File "/home/runner/work/cpython/cpython/Lib/test/test_ttk_guionly.py", line 30 in test_main
  File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest.py", line 234 in _runtest_inner2
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest.py", line 270 in _runtest_inner
  File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest.py", line 140 in _runtest
  File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest.py", line 193 in runtest
  File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest_mp.py", line 80 in run_tests_worker
  File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/main.py", line 654 in _main
  File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/main.py", line 634 in main
  File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/main.py", line 712 in main
  File "/home/runner/work/cpython/cpython/Lib/test/regrtest.py", line 43 in _main
  File "/home/runner/work/cpython/cpython/Lib/test/regrtest.py", line 47 in <module>
  File "/home/runner/work/cpython/cpython/Lib/runpy.py", line 86 in _run_code
  File "/home/runner/work/cpython/cpython/Lib/runpy.py", line 193 in _run_module_as_main

== Tests result: FAILURE ==

@1st1
Copy link
Member

1st1 commented Feb 27, 2020

I'll close/reopen the PR to rerun the CI

@1st1 1st1 closed this Feb 27, 2020
@1st1 1st1 reopened this Feb 27, 2020
@1st1
Copy link
Member

1st1 commented Feb 27, 2020

Please add a NEWS entry with blurb and update what's new

@lidizheng
Copy link
Contributor Author

@1st1 Thanks for the quick review. I have updated the blurb (first time using this tool).

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #18669 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18669     +/-   ##
=========================================
  Coverage   82.12%   82.13%             
=========================================
  Files        1956     1955      -1     
  Lines      589798   584496   -5302     
  Branches    44477    44481      +4     
=========================================
- Hits       484388   480047   -4341     
+ Misses      95756    94802    -954     
+ Partials     9654     9647      -7
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
... and 328 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21da76d...480dbda. Read the comment docs.

asvetlov
asvetlov approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lidizheng
Copy link
Contributor Author

@asvetlov Is there any additional work I need to do to get this PR merged?

@asvetlov
Copy link
Contributor

asvetlov commented Mar 2, 2020

No, everything is perfect!
Merging.

@asvetlov asvetlov merged commit 4482337 into python:master Mar 2, 2020
@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @lidizheng for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2020
@lidizheng @miss-islington
bpo-39764: Make Task.get_stack accept ag_frame (pythonGH-18669)
f5863a8 
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 4482337)

Co-authored-by: Lidi Zheng <scallopsky@gmail.com>
@bedevere-bot
Copy link

GH-18742 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Mar 2, 2020
@miss-islington @lidizheng
bpo-39764: Make Task.get_stack accept ag_frame (GH-18669)
43932dc 
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 4482337)

Co-authored-by: Lidi Zheng <scallopsky@gmail.com>
@lidizheng lidizheng mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lidizheng @the-knights-who-say-ni @1st1 @asvetlov @bedevere-bot @miss-islington