Skip to content

bpo-39770: Remove unnecessary descriptor counting #18675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2020
Merged

bpo-39770: Remove unnecessary descriptor counting #18675

merged 1 commit into from
Mar 4, 2020

Conversation

petdance
Copy link
Contributor

@petdance petdance commented Feb 27, 2020

The array_modexec function in Modules/arraymodule.c has a loop that calculates the number of elements in the descriptors array. This size was used at one point, but is no longer. The loop can be removed.

https://bugs.python.org/issue39770

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petdance

Thank you for the contribution.
This is nice catch :)

@vstinner
Copy link
Member

vstinner commented Mar 4, 2020

Likely a ghost from the past.

@petdance petdance deleted the bpo-39770-D branch March 5, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants