Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-28577: Special case added to IP v4 and v6 hosts for /32 and /128 networks #18757

Merged
merged 7 commits into from Mar 9, 2020
Merged

bpo-28577: Special case added to IP v4 and v6 hosts for /32 and /128 networks #18757

merged 7 commits into from Mar 9, 2020

Conversation

JamoBox
Copy link
Contributor

@JamoBox JamoBox commented Mar 2, 2020 •
edited

Calling hosts() on a /32 IPv4Network now returns a list containing the IPv4Address instead of an empty list.
The same also happens for /128 IPv6Networks

https://bugs.python.org/issue28577

@codecov

This comment has been minimized.

Sign in to view
JamoBox and others added 2 commits Mar 3, 2020
@JamoBox
Special case added to IPv6Network hosts for /128 networks
b7c888a 
Signed-off-by: Pete Wicken <petewicken@gmail.com>
@JamoBox
Updated News
1c28891 
Added IPv6 update to news
@JamoBox JamoBox changed the title bpo-28577: Special case added to IPv4Network hosts for /32 networks bpo-28577: Special case added to IP v4 and v6 hosts for /32 and /128 networks Mar 3, 2020
ethanfurman
ethanfurman requested changes Mar 3, 2020
View changes
Copy link
Member

@ethanfurman ethanfurman left a comment

According to Travis there is a file with whitespace issues, and some problem with the docs.

Otherwise, it looks good to me!

@bedevere-bot
Copy link

bedevere-bot commented Mar 3, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@JamoBox
Copy link
Contributor Author

JamoBox commented Mar 3, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Mar 3, 2020

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ethanfurman Mar 3, 2020
ethanfurman
ethanfurman approved these changes Mar 3, 2020
View changes
Copy link
Member

@ethanfurman ethanfurman left a comment

Looks good!

I'll give it a couple days in case somebody else want to chime in. Feel free to ping me early next week if this PR is still open.

@JamoBox
Copy link
Contributor Author

JamoBox commented Mar 9, 2020

Looks good!

I'll give it a couple days in case somebody else want to chime in. Feel free to ping me early next week if this PR is still open.

No updates on here or on BPO - do we want to leave it open a bit longer or are you happy to sign off on it?

@ethanfurman ethanfurman merged commit 8e9c47a into python:master Mar 9, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Mar 9, 2020

Thanks @JamoBox for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 9, 2020

Thanks @JamoBox for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 9, 2020

Sorry, @JamoBox and @ethanfurman, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e9c47a947954c997d4b725f4551d50a1d896722 3.6

@miss-islington
Copy link
Contributor

miss-islington commented Mar 9, 2020

Sorry @JamoBox and @ethanfurman, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e9c47a947954c997d4b725f4551d50a1d896722 3.7

@ethanfurman
Copy link
Member

ethanfurman commented Mar 9, 2020

Will need to do the backports after the RCs are published.

@JamoBox JamoBox deleted the bpo-28577 branch Mar 12, 2020
@mathieui
Copy link

mathieui commented Apr 12, 2021

Hi there, sorry for the noise; it looks like the backports did not happen, did they?

JamoBox added a commit to JamoBox/cpython that referenced this pull request Apr 22, 2021
@JamoBox
[3.6] bpo-28577: Special case added to IP v4 and v6 hosts for /32 and…
2daa758 
… /128 networks (pythonGH-18757)

The `.hosts()` method now returns the single address present in a /32 or /128 network..
(cherry picked from commit 8e9c47a)

Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
This was referenced Apr 22, 2021
Closed
Closed
JamoBox added a commit to JamoBox/cpython that referenced this pull request Apr 22, 2021
@JamoBox
[3.7] bpo-28577: Special case added to IP v4 and v6 hosts for /32 and…
8deee8b 
… /128 networks (pythonGH-18757)

The `.hosts()` method now returns the single address present in a /32 or /128 network..
(cherry picked from commit 8e9c47a)

Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 22, 2021

GH-25533 is a backport of this pull request to the 3.7 branch.

@JamoBox JamoBox mentioned this pull request Apr 22, 2021
Merged
JamoBox added a commit to JamoBox/cpython that referenced this pull request Apr 22, 2021
@JamoBox
[3.8] bpo-28577: Special case added to IP v4 and v6 hosts for /32 and…
541c502 
… /128 networks (pythonGH-18757)

The `.hosts()` method now returns the single address present in a /32 or /128 network..
(cherry picked from commit 8e9c47a)

Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
@JamoBox
Copy link
Contributor Author

JamoBox commented Apr 22, 2021

Hi there, sorry for the noise; it looks like the backports did not happen, did they?

Yep, totally forgot about these - PRs are in for 3.6, 3.7 and 3.8 now. Thanks!

ambv pushed a commit that referenced this pull request Apr 26, 2021
@JamoBox
[3.8] bpo-28577: Special case added to IP v4 and v6 hosts for /32 and…
10ad7eb 
… /128 networks (GH-18757) (#25536)

The `.hosts()` method now returns the single address present in a /32 or /128 network..
(cherry picked from commit 8e9c47a)

Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman

Assignees

@ethanfurman ethanfurman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JamoBox @bedevere-bot @miss-islington @ethanfurman @mathieui @the-knights-who-say-ni