Skip to content

/ devguide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that bpo issues can be automatically closed using commit message #502

Open
Mariatta opened this issue Jun 27, 2019 · 2 comments
Open

Document that bpo issues can be automatically closed using commit message #502

Mariatta opened this issue Jun 27, 2019 · 2 comments
Labels
good first issue help wanted

Comments

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Jun 27, 2019

According to PEP 595, bpo now has a feature where issues can be automatically closed, if the PR commit message looks like closes bpo-NNNN: ...

This should be documented in devguide and announced to core devs/core-workflow mailing list/discourse.

Some questions: what magic keywords accepted? "closes" "fixes" "close" "fix"?
Is it case sensitive? (I assume not)

Does it also update the "resolution" / "stage"?
@webknjaz
Copy link

@webknjaz webknjaz commented Jun 29, 2019

Better follow what GitHub has: https://help.github.com/en/articles/closing-issues-using-keywords
This way people won't have to relearn which words work on which platform
Mariatta referenced this issue in python/peps Jul 9, 2019
@Mariatta
PEP 581 Updates (#1114)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5f56c05 
- include recent changes to bpo
- clarify the downsides of GitHub
@Mariatta Mariatta mentioned this issue Jul 9, 2019
Merged
@Mariatta
Copy link
Member Author

@Mariatta Mariatta commented Jul 11, 2019

Reading bpo's source code, the magic words are matching this regex

VERBS = r'(?:\b(?P<verb>close[sd]?|closing|fix(?:e[sd])?|)\s+)?'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@webknjaz @Mariatta
You can’t perform that action at this time.