Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39572:documented _total_ attribute of TypedDict #18554

Merged
merged 5 commits into from Feb 19, 2020
Merged

bpo-39572:documented _total_ attribute of TypedDict #18554

merged 5 commits into from Feb 19, 2020
+29 −3

Conversation

@ananthan-123
Copy link
Contributor

ananthan-123 commented Feb 18, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39572
@ananthan-123
documented _total_ argument of TypeDict
Loading status checks…
82afbb1
@ananthan-123 ananthan-123 requested review from gvanrossum and ilevkivskyi and removed request for gvanrossum and ilevkivskyi Feb 18, 2020
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d5b6107
@ananthan-123 ananthan-123 changed the title bpo-39572:documented _total_ attribute of TypeDict bpo-39572:documented _total_ attribute of TypedDict Feb 18, 2020
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #18554 into master will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18554       +/-   ##
===========================================
+ Coverage   82.11%   83.19%    +1.08%     
===========================================
  Files        1956     1571      -385     
  Lines      589145   414757   -174388     
  Branches    44447    44457       +10     
===========================================
- Hits       483801   345075   -138726     
+ Misses      95697    60030    -35667     
- Partials     9647     9652        +5
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 452 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fac7ed...d5b6107. Read the comment docs.
@gvanrossum

This comment has been minimized.

Sign in to view
Copy link
Member

gvanrossum commented Feb 19, 2020

Note that the importlib failure is pre-existing (and presumably being worked on). I'll try to review later, but I am going out of town for a ew days.
@gvanrossum
gvanrossum requested changes Feb 19, 2020
View changes
Misc/NEWS.d/next/Documentation/2020-02-18-18-37-07.bpo-39572.CCtzy1.rst Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 19, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@ananthan-123
Update 2020-02-18-18-37-07.bpo-39572.CCtzy1.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
86f61e8
@gvanrossum
gvanrossum reviewed Feb 19, 2020
View changes
Copy link
Member

gvanrossum left a comment

Attribute -> flag, and you’re golden.
ananthan-123 and others added 2 commits Feb 19, 2020
@ananthan-123
Update 2020-02-18-18-37-07.bpo-39572.CCtzy1.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
62a9544
@gvanrossum
Fixed markup.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd1ddb8
@gvanrossum
gvanrossum approved these changes Feb 19, 2020
View changes
@gvanrossum gvanrossum merged commit ab6423f into python:master Feb 19, 2020
8 of 9 checks passed
8 of 9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200219.5 succeeded with issues
Details
bedevere/issue-number Issue number 39572 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 19, 2020

Thanks @ananthan-123 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 19, 2020

GH-18556 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Feb 19, 2020
@miss-islington @ananthan-123
bpo-39572: Document ’total’ flag of TypedDict (GH-18554)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
44c6901 
(cherry picked from commit ab6423f)

Co-authored-by: ananthan-123 <ananthakrishnan15.2001@gmail.com>
petdance added a commit to petdance/cpython that referenced this pull request Feb 19, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
52663b6
petdance added a commit to petdance/cpython that referenced this pull request Feb 20, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
6d1f5c0
petdance added a commit to petdance/cpython that referenced this pull request Feb 20, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
c126764
petdance added a commit to petdance/cpython that referenced this pull request Feb 20, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
038d4bc
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
8bffb9b
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
ede9869
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
a35ad29
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
d0e9463
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
47ac155
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
77342cd
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
1f34d26
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
a3a30a5
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
060fee4
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
e0f37ad
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
2c7eadc
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
dd4d9f9
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
eb3bb2b
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
459bd61
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
12a614f
petdance added a commit to petdance/cpython that referenced this pull request Feb 21, 2020
@ananthan-123 @petdance
bpo-39572: Document ’total’ flag of TypedDict (pythonGH-18554)
e59b171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@ilevkivskyi ilevkivskyi

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@ananthan-123 @gvanrossum @bedevere-bot @miss-islington @the-knights-who-say-ni
You can’t perform that action at this time.