Skip to content

/ peps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the PR template and Contributing Guidelines #738

Merged
merged 2 commits into from Jul 13, 2018
Merged

Update the PR template and Contributing Guidelines #738

merged 2 commits into from Jul 13, 2018

Conversation

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Jul 12, 2018

Mention about signing the CLA, and additional steps before writing up a PEP.

I copied over text from
#158 (comment)
and
#158 (comment)

Closes #158
@Mariatta
Update the PR template and Contributing Guidelines
Verified
This commit was signed with a verified signature.
Mariatta Mariatta Wijaya
GPG key ID: BA945C6FDC901250 Learn about signing commits
Loading status checks…
44b4e81 
Mention about signing the CLA, and additional steps before writing up a PEP.

Closes #158
@Mariatta
remove triple quotes, seem unnecessary
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0969cbf
@pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Jul 13, 2018

Should the PR template also mention that there's a checklist to be completed before submitting in the contributing guidelines?

Or just include that checklist within the PR template, as originally proposed?
@brettcannon
brettcannon approved these changes Jul 13, 2018
View changes
@brettcannon brettcannon merged commit 82fd1fe into python:master Jul 13, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Jul 13, 2018

@pradyunsg it should be one or the other, but not both as that leads to skew. For now we can leave it as @Mariatta implemented it and see how it goes.
@Mariatta Mariatta deleted the Mariatta:issue-158 branch Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Mariatta @pradyunsg @brettcannon @the-knights-who-say-ni