This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($aria): get the docs working for the service #16945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chivesrs
changed the title
12 tasks
|
Looks like the travis build failed due to an internal error, and not something due to this PR. |
gkalpak
approved these changes
Feb 7, 2020
|
Good catch! Thx for, @chivesrs 👍 |
gkalpak
pushed a commit
that referenced
this pull request
Feb 7, 2020
This was referenced Feb 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AngularJS is in LTS mode
We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.
Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
Yes
What is the current behavior? (You can also link to an open issue here)
Docs don't work for
$aria.What is the new behavior (if this is a feature change)?
Docs work for
$aria.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
Apparently
@prioritybroke this, and that doc annotation is only meant for directives, not services.Here is an example of the working docs:
