fix($location): don't rewrite when link is shift-clicked #9906

caitp · 2014-11-04T16:16:34Z

caitp · 2014-11-04T16:19:17Z

test/ng/locationSpec.js

@@ -1471,6 +1471,19 @@ describe('$location', function() {
    });


+    it('should not rewrite when clicked with shift pressed', function() {
+      configureService({linkHref: 'base/a?b=c', html5Mode: true, supportHist: true});


ping @tbosch --- the other tests in this suite don't seem to be quite right. In testing, even without this fix, if linkHref was not preceded with base/, we would not rewrite anyways because we would determine the link to not be within the app url. So I think something is a bit wrong with these tests.

However, with the test written like this, without the fix we fail and with we pass.

tbosch · 2014-11-07T01:03:04Z

@caitp Please ask @petebacondarwin to review. Really busy...

caitp · 2015-01-23T18:58:09Z

3 months later, bitrotten patch, and no comment from assigned reiewer. @petebacondarwin were you going to do this? it's a one liner

petebacondarwin · 2015-01-23T19:11:41Z

:-) - I'll look over the weekend.

Closes #9904 Closes #9906

petebacondarwin · 2015-01-25T00:42:18Z

Added a second commit that fixes the tests you pointed out @caitp - 2f32614

fix($location): don't rewrite when link is shift-clicked

07c9c87

Closes angular#9904

caitp reviewed Nov 4, 2014
View changes

caitp added component: $location type: bug severity: inconvenient severity: confusing labels Nov 4, 2014

caitp added this to the 1.3.x milestone Nov 4, 2014

caitp assigned tbosch Nov 4, 2014

mary-poppins added cla: yes and removed cla: no labels Nov 4, 2014

tbosch assigned petebacondarwin and unassigned tbosch Nov 7, 2014

caitp closed this in angular/angular.js@8b33de6 Jan 25, 2015

petebacondarwin added a commit that referenced this issue Jan 25, 2015

fix($location): don't rewrite when link is shift-clicked

939ca37

Closes #9904 Closes #9906

angular / angular.js Public archive

fix($location): don't rewrite when link is shift-clicked #9906

fix($location): don't rewrite when link is shift-clicked #9906

caitp commented Nov 4, 2014

caitp Nov 4, 2014

tbosch commented Nov 7, 2014

caitp commented Jan 23, 2015

petebacondarwin commented Jan 23, 2015

petebacondarwin commented Jan 25, 2015

angular / angular.js Public archive

fix($location): don't rewrite when link is shift-clicked #9906

fix($location): don't rewrite when link is shift-clicked #9906

Conversation

caitp commented Nov 4, 2014

caitp Nov 4, 2014

Choose a reason for hiding this comment

tbosch commented Nov 7, 2014

caitp commented Jan 23, 2015

petebacondarwin commented Jan 23, 2015

petebacondarwin commented Jan 25, 2015