Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] bpo-36147: Fix a variable going out of scope. #12102

Merged
merged 1 commit into from Mar 6, 2019
Merged

[2.7] bpo-36147: Fix a variable going out of scope. #12102

merged 1 commit into from Mar 6, 2019

Conversation

stratakis
Copy link
Contributor

@stratakis stratakis commented Feb 28, 2019 •
edited by bedevere-bot

The s_get function leaks the result variable.
Partially backport commit 19b5254
to fix it.

https://bugs.python.org/issue36147

@stratakis
bpo-36147: Fix a variable going out of scope.
d914643 
The s_get function leaks the result variable.
Partially backport commit 19b5254
to fix it.
vstinner
vstinner approved these changes Mar 4, 2019
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM, that's a copy of the code used in the master branch.

@vstinner vstinner merged commit 098b139 into python:2.7 Mar 6, 2019
@stratakis stratakis deleted the bpo36147 branch Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stratakis @vstinner @the-knights-who-say-ni @bedevere-bot