Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 's' mention as there's no argument for set.copy() #12176

Merged
merged 1 commit into from Mar 7, 2019

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Mar 5, 2019

Wording is taken from dict.copy()

@merwok
Copy link
Member

merwok commented Mar 5, 2019

Thanks! Can you check if the method docstring has the same problem?

@andresdelfino
Copy link
Contributor Author

andresdelfino commented Mar 5, 2019

Thanks! Can you check if the method docstring has the same problem?

Sure! It doesn't:

PyDoc_STRVAR(copy_doc, "Return a shallow copy of a set.");

merwok
merwok approved these changes Mar 5, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Mar 7, 2019

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 7, 2019
Remove 's' mention as there's no argument.
(cherry picked from commit e942e7b)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 7, 2019

GH-12206 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 7, 2019
Remove 's' mention as there's no argument.
(cherry picked from commit e942e7b)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 7, 2019

GH-12207 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this pull request Mar 7, 2019
Remove 's' mention as there's no argument.
(cherry picked from commit e942e7b)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Mar 7, 2019
Remove 's' mention as there's no argument.
(cherry picked from commit e942e7b)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the fix-set-copy branch Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants