Skip to content

bpo-34203: FAQ: minor additional rewording and fix a few typos #9821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Oct 12, 2018

This is following up @augustogoulart's recent change to the "How stable is Python?" FAQ section, recommending 3.x over 2.x.

Upon reading the final build version, I noticed a few typos and an over-abundant use of the name "Python". This is a minor revision fixing those issues.

https://bugs.python.org/issue34203

This is following up the recent change to this section recommending
3.x over 2.x.
@taleinat taleinat requested a review from JulienPalard October 12, 2018 12:18
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Oct 12, 2018
@taleinat taleinat changed the title bpo-34203: minor additional rewording and fix a few typos bpo-34203: FAQ: minor additional rewording and fix a few typos Oct 12, 2018
of Python: 2.x and 3.x, with the recommended one at this time being 3.x.
Although 2.x is still widely used, `it will not be maintained after
January 1, 2020 <https://www.python.org/dev/peps/pep-0373/>`_. 2.x was known
for having more third-party libraries available; however, by the time of this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you keep this, I would make it "at the time of this".

<https://www.python.org/downloads/>`_. There are two production-ready versions
of Python: 2.x and 3.x, with the recommended one at this time being 3.x.
Although 2.x is still widely used, `it will not be maintained after
January 1, 2020 <https://www.python.org/dev/peps/pep-0373/>`_. 2.x was known
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd drop the historical "2.x used to be better" wording, and just make this "Python 3.x is supported by most widely used libraries".

by the time of this writing, most of the widely used libraries support Python 3.x,
and some are even dropping the Python 2.x support.
<https://www.python.org/downloads/>`_. There are two production-ready versions
of Python: 2.x and 3.x, with the recommended one at this time being 3.x.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of 'at this time', you could consider 'as of October 2018', as that clarifies the time at which the text was written. Although it's also fair to assume that the recommendation will be valid until the rest of the text is also rewritten. (same for the 'at this time' at line 319)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also just drop "at this time", since the recommended version is going to be 3.x in the foreseeable future.

@vstinner
Copy link
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@csabella
Copy link
Contributor

@taleinat This is a good improvement over the current wording. In the last comment you mentioned dropping 'at this time', which I agree with. It would be great if this could be merged soon. :-)

@taleinat
Copy link
Contributor Author

I've updated the wording following the comments here.

@taleinat taleinat merged commit 6cd658b into python:master Mar 26, 2019
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-12567 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-12568 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 26, 2019
…nGH-9821)

(cherry picked from commit 6cd658b)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 26, 2019
…nGH-9821)

(cherry picked from commit 6cd658b)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Mar 26, 2019
…H-9821) (GH-12568)

(cherry picked from commit 6cd658b)


Co-authored-by: Tal Einat <taleinat+github@gmail.com>


https://bugs.python.org/issue34203
miss-islington added a commit that referenced this pull request Mar 26, 2019
(cherry picked from commit 6cd658b)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants