Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Colors rewrite #30622
Colors rewrite #30622
Conversation
|
I really prefer the percentage values you're suggesting to remove |
|
Is this safe to bring back and set to ready for review for Alpha 3? |
MartijnCuppens
force-pushed the
master-mc-colors
branch
2 times, most recently
from
2f1ae1a
to
27dba2e
|
Yeah, fine by me. Worked a bit on this today, but it seemed to be a bit more complex than I initially thought. I'll keep you posted. Edit: It's done ;) |
|
LGTM, really helpful changes! |
|
Hell yeah, huge refactor and update, @MartijnCuppens! |
|
Any reason to implement this change using black and white (essentially working in HWB) rather than using Sass's |
Purpose of this PR is to use a uniform approach on using colors:
tint-color()to replacelighten()shade-color()to replacedarken()scale-color()to replacecolor-level()(since we don't work with levels anymore)$theme-color-interval, the8%levels are hard to calculate with.vs
(color contrast on the light variants is still an issue, but can be tackled later on to prevent this PR from being too overwhelming)