Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/eslint-unused-modules does not check .ts files #89

Closed
muan opened this issue Mar 2, 2020 · 2 comments
Closed

bin/eslint-unused-modules does not check .ts files #89

muan opened this issue Mar 2, 2020 · 2 comments
Assignees

Comments

@muan
Copy link
Contributor

@muan muan commented Mar 2, 2020

https://github.com/github/eslint-plugin-github/blob/master/bin/eslint-unused-modules.js

All the exports in our new TS files are currently unchecked. 😬

@koddsson
Copy link
Member

@koddsson koddsson commented Mar 3, 2020

I think this is because eslint defaults to files with a .js extension. Since our script takes in file globs we could just pass globs that include the .ts extension as a bin/eslint-unused-modules src/**/*.ts.

I looked into this a bit though and was hoping we could drop our custom solution for something built into TypeScript. I didn't find anything build into TypeScript but I did find this gist that seems to yield correct results. I also timed the gist against our solution and the gist clocks in at around 13 seconds whereas our solution takes 50 seconds.

@koddsson
Copy link
Member

@koddsson koddsson commented Apr 14, 2020

I think github/github#140799 is a good indicator that we might want this check still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.