Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbin/eslint-unused-modules does not check .ts files #89
Comments
I think this is because eslint defaults to files with a I looked into this a bit though and was hoping we could drop our custom solution for something built into TypeScript. I didn't find anything build into TypeScript but I did find this gist that seems to yield correct results. I also timed the gist against our solution and the gist clocks in at around 13 seconds whereas our solution takes 50 seconds. |
I think github/github#140799 is a good indicator that we might want this check still. |
https://github.com/github/eslint-plugin-github/blob/master/bin/eslint-unused-modules.js
All the exports in our new TS files are currently unchecked.😬