Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upESM browser build still contains references to process.env #1730
Comments
pearofducks
changed the title
|
Thank you so much for the report! I'll create a fix. |
|
OK seems like this happened when we forward port Vuex 3 to Vuex 4, where Vuex 3 uses I'll include the fix in #1729. |
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
4.0.0-beta.1
Reproduction link
https://unpkg.com/vuex@4.0.0-beta.1/dist/vuex.esm-browser.js
Steps to reproduce
Compare build from 3.3.0
https://unpkg.com/vuex@3.3.0/dist/vuex.esm.browser.js
to build for 4.0.0-beta.1
https://unpkg.com/vuex@4.0.0-beta.1/dist/vuex.esm-browser.js
What is expected?
No references to
process.envWhat is actually happening?
References to
process.envwhich cause it to not be usable in the browser.Original issue creating these builds - #1247
Resolving this is blocking Vuex use in Vite