Skip to content
#

snapshot-testing

Here are 159 public repositories matching this topic...

hollanderbart
hollanderbart commented Feb 20, 2019

Hi @stephencelis,

Thanks for creating this snapshot testing framework!
I was comparing this framework with the other snapshot framework (https://github.com/uber/ios-snapshot-test-case)(FBSnapshotTestCase) to know which features are supported.

What I like about this framework is the API, in which you can easily specify the device (iPhoneSE or iPad), while for with the FBSnapshotTestCase you

Eightyplus
Eightyplus commented Jun 15, 2019

rendering a component with <> ... </> seems troublesome and often return null instead of children

functional-component.js

import React from 'react';
export default ({ message }) => <span>{message}</span>;

component.js

import React from 'react';

import FunctionalComponent from './functional-component';

export default ({ message, show }) => {
  return (
    <>
  
claremacrae
claremacrae commented Mar 31, 2020

Having spent several hours yesterday pairing with a new user, we copied a lot of examples from our docs, and in every case, we had to paste in our namespace ApprovalTests:: - it got very old, very quickly - and I ended up agreeing with this:

https://twitter.com/lefticus/status/1207890691948339200

Please, I implore you, in the name of all that is good, do NOT use using namespace in

bradleyjkemp
bradleyjkemp commented May 2, 2018

The built in error message is very opaque (necessary because it has to be generic) but users can likely provide a more helpful friendly message customised to their tests (or e.g. when the diff just isn't useful). Therefore an option to customise this message would be useful.

This would only really be usable once #28 is implemented.

DavidFrahm
DavidFrahm commented Dec 3, 2018

I would love to see this repo cover a scenario where you navigate across pages. Ideally covering navigation handled two ways: one via a simple stencil route link, and another via a button which calls a function to programatically navigate.

For example:

  1. Load the root url: "/"
  2. Find a navigation link: <stencil-route-link url='/page-2' ...
  3. Click the link
  4. Assert page is Page 2
iamogbz
iamogbz commented Feb 29, 2020

Current tests are starting to be hard to reason about. Some clarification about the behaviour each test is attempting to verify is getting more essential.

Describe the solution you'd like

Make each test case group a single file testing all the behaviours with module and test doc string explaining the purpose

Describe alternatives you've considered
N/A

Additional context
T

Improve this page

Add a description, image, and links to the snapshot-testing topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the snapshot-testing topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.