Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProvide a quick-fix for non-exported types #37440
Comments
@DanielRosenwasser / @RyanCavanaugh I can get time and work on this. Quick question, which files generally have the code for Domain "Quick Fixes"? |
It's all in class C {
foo = 10;
bar() {
foo; // oops! needs to be prefixed with `this.`
}
} |
Sorry, I meant |
Thanks a lot :) |
@AGMETEOR Are you still working on this issue? If not, I'm looking for an opportunity to begin contributing. :) |
@jjpiv yes, I am working on it |
@jjpiv please take this on if you still want to. |
@jjpiv Did you take this? If not I'd like to take a shot :) |
I'm working on this issue, currently stuck at getting SourceFile object for
|
@Qiyu8 I think that information is in the context that's passed to |
@AGMETEOR Thanks for your advise, would you mind reviewing the code? |
@Qiyu8 I think @DanielRosenwasser is the one that reviews. I am also still quite a new contributor :) |
In #36187, @a-tarasyuk wrote up a handy error message for non-exported types. We should provide a quick fix to add the
export
modifier for declarations like this that aren't innode_modules
and the like.