Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review skip links theming #30491

Open
MartijnCuppens opened this issue Mar 31, 2020 · 5 comments
Open

Review skip links theming #30491

MartijnCuppens opened this issue Mar 31, 2020 · 5 comments
Assignees
Labels

Comments

@MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Mar 31, 2020

In #30414 we discovered the skip links do not look that well if backported to v4:
image

We could also improve the theming in v5, in some viewports, it also covers a critical part of the navbar
image

CC @patrickhlauke @ffoodd

@MartijnCuppens MartijnCuppens added this to Inbox in v5.0.0-alpha2 via automation Mar 31, 2020
@MartijnCuppens
Copy link
Member Author

@MartijnCuppens MartijnCuppens commented Mar 31, 2020

Maybe we can just add one of the .btn classes here?

@ffoodd
Copy link
Contributor

@ffoodd ffoodd commented Mar 31, 2020

We may try. FWIW what's important with my PR IS making them top left: we may get the previous styling back, but simply left align links.

And maybe display both of them at the same time in docs template, BTW.

@ffoodd
Copy link
Contributor

@ffoodd ffoodd commented Mar 31, 2020

Could also be a navbar, otherwise.

@ffoodd ffoodd self-assigned this Apr 1, 2020
@ffoodd
Copy link
Contributor

@ffoodd ffoodd commented Apr 1, 2020

Let me try something :)

@vishalsharma2063

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5.0.0-alpha2
  
Inbox
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.