Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement in memory statistics #1280

Open
WojciechNagorski opened this issue Oct 14, 2019 · 1 comment
Open

Improvement in memory statistics #1280

WojciechNagorski opened this issue Oct 14, 2019 · 1 comment

Comments

@WojciechNagorski
Copy link
Collaborator

@WojciechNagorski WojciechNagorski commented Oct 14, 2019

I think that empty GC memory statistics can mislead users. In #1250 I create comment:

@adamsitnik I think that BenchmarkDotNet should not print information about GC if it doesn't run extra iteration. I mean this line:

GC:  0 0 0 0 0
Threading:  0 0 0

Extra iteration runs only when user adds MemoryDiagnoser or ThreadingDiagnoser. In other cases we shouldn't print these lines:

outWriter.WriteLine(GCStats.ToOutputLine());
outWriter.WriteLine(ThreadingStats.ToOutputLine());

Or even more precisely:
GC: 0 0 0 0 0 should print only with MemoryDiagnoser
Threading: 0 0 0 should print only with ThreadingDiagnoser

@adamsitnik What do you think?

@adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Oct 14, 2019

If this does not require a lot of changes in the code, then I am ok with that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.