Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance Task] - Review ESLint settings and fix linting issues #3224

Open
matthew-dean opened this issue Jun 21, 2018 · 0 comments
Open

[Maintenance Task] - Review ESLint settings and fix linting issues #3224

matthew-dean opened this issue Jun 21, 2018 · 0 comments

Comments

@matthew-dean
Copy link
Member

@matthew-dean matthew-dean commented Jun 21, 2018

A while ago I switched the project from JSHint to ESLint (the latter being better-maintained and offering more features). However, I set many of the settings as warnings because I didn't have time to address potential issues. Nor did I really have time to tweak linting for settings that make the code more maintainable.

So, the task would essentially be to look at ESLint warnings, and see what can be safely addressed. (For example, a lot of the == equality warnings may not be "fixable" to === without testing for every value that passes through that check.) It would be helpful to also set warnings for things to address in the future / ongoing, such as enforcing JSDoc documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.