Skip to content

Update wording of what multiplyAll should do in "Nesting For Loops" #38852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2020
Merged

Update wording of what multiplyAll should do in "Nesting For Loops" #38852

merged 1 commit into from
May 31, 2020

Conversation

ExperimentMonty
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #38317

There was apparently some confusion of the wording in this problem, so this change was suggested to make the intent more easily understood.

@gitpod-io
Copy link

gitpod-io bot commented May 19, 2020

@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels May 22, 2020
ShaunSHamilton
ShaunSHamilton approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you, for getting this done. Please note that there is a temporary block for merging PRs. Once that is removed, this can be given one more approval, and be merged.

@ExperimentMonty
Copy link
Contributor Author

You’re welcome, glad to help!

moT01
moT01 approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ExperimentMonty 🎉 Congratulations on your first contribution to the freeCodeCamp codebase 🎉

@moT01 moT01 merged commit 5cd850f into freeCodeCamp:master May 31, 2020
abbathaw pushed a commit to abbathaw/freeCodeCamp that referenced this pull request Jul 24, 2020
@ExperimentMonty @abbathaw
Update wording of what multiplyAll should do in "Nesting For Loops" (…
c458a00 
…freeCodeCamp#38852)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@thecodingaviator thecodingaviator thecodingaviator approved these changes

@ShaunSHamilton ShaunSHamilton ShaunSHamilton approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong instructions
5 participants
@ExperimentMonty @moT01 @thecodingaviator @ShaunSHamilton @camperbot