Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kd/mount: mount index should not count directories #10741

Open
ppknap opened this issue Mar 9, 2017 · 0 comments
Open

kd/mount: mount index should not count directories #10741

ppknap opened this issue Mar 9, 2017 · 0 comments
Assignees
Projects

Comments

@ppknap
Copy link
Contributor

@ppknap ppknap commented Mar 9, 2017

Counting directories results in invalid number of reported files and incorrect size. Since directory sizes may differ between OSes/File systems counting them is inaccurate. Eg:

Having directory structure like below will result in 3 files being reported (., A directories each 4094 bytes and 2-byte a.txt file)

Probably we should not synchronize folders at all and behave like git - empty folders will not be synchronized (however they will be visible)

(archpk) ~/tmp/mount/test$ tree -s
.
├── [       4096]  A
└── [          2]  a.txt

1 directory, 1 file

Problem: https://asciinema.org/a/5j5yhdb1n16p2n1vuyb6e8nsk

@ppknap ppknap added the Category-KD label Mar 9, 2017
@ppknap ppknap self-assigned this Mar 10, 2017
@ppknap ppknap added the Priority-Mid label Mar 10, 2017
@ppknap ppknap added this to BACKLOG in KD / kd.io Apr 26, 2017
@ppknap ppknap changed the title Mount index should not count directories kd/mount: mount index should not count directories Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
KD / kd.io
BACKLOG
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.