Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReloading gists when switching from gists to local #96
Comments
Hello @kodaman2, |
I'll see what I can come up for this issue. |
Maybe just use this package? |
I've tried it and it seems to work quite nicely. Maybe this is already good enough for now and something to work with? |
I'll take a look at it tonight. Looks like is heading in the right direction. |
You give it a go then. Didn't want to steal this issue from you! :( |
@jodli You're good, I'll try to submit a commit to your PR and that way is both our idea. |
Ok, now that I am done with the ghe auth PR, I can get back to this one. It might take me a little longer but cache or avoiding full notes reload will be implemented no doubt : ) After looking at the way the notes are loaded, it appears after each action (delete, edit, create), we fired up What I am thinking is that after each edit, I'm going to update just each NoteCard without refreshing NotesList. And after create, or delete reactively update NotesList component without all the overhead of all the http gists requests. Of course we'll have to check github if any gists are added so |
Describe the bug
Repetitive loading have you waiting on gists loading.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I think the loaded gists should remain loaded even when going to local, and maybe have a refresh button if you want to pull new gists from profile. I have about 20+ gists not much, and I have to wait a few seconds before seeing my gists load.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):