Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default MySQL to utf8mb4 #11081

Open
silverwind opened this issue Apr 15, 2020 · 0 comments
Open

Default MySQL to utf8mb4 #11081

silverwind opened this issue Apr 15, 2020 · 0 comments

Comments

@silverwind
Copy link
Member

@silverwind silverwind commented Apr 15, 2020

#11032 will output unicode emoji from tokens and attempting to save such a emoji into a utf8 table will result in error 500:

CreateIssueComment: Error 1366: Incorrect string value: '\xF0\x9F\x91\x8E' for column 'content' at row 1

I think we should:

  1. default new installs to utf8mb4
  2. mention in the release notes that MySQL users are encouraged to update their config to utf8mb4 and then run gitea convert to upgrade the database.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.