Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .env file to .gitignore for vscode environment settings #35200

Merged
merged 1 commit into from May 17, 2020

Conversation

@teharris1
Copy link
Contributor

teharris1 commented May 4, 2020

Proposed change

Ignore .env file in VSCode to allow environmental settings.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum
@project-bot project-bot bot added this to Needs review in Dev May 4, 2020
@teharris1 teharris1 changed the title Exclude .env file for vscode environment settings git ignore .env file for vscode environment settings May 11, 2020
Dev automation moved this from Needs review to Reviewer approved May 17, 2020
@MartinHjelmare MartinHjelmare changed the title git ignore .env file for vscode environment settings Add .env file to .gitignore for vscode environment settings May 17, 2020
@MartinHjelmare MartinHjelmare merged commit 71d41cb into home-assistant:dev May 17, 2020
13 checks passed
13 checks passed
CI Build #20200504.93 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Docker) Overview Docker succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
CI (Tests PyTest Python38) Tests PyTest Python38 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing dbf383f...35ff8a4
Details
codecov/project 95.03% (target 90.00%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.