Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Export marble diagram images from tests #766
Comments
Yep, I'm open to supporting this case From a quick glance at the code you linked, we can reuse the I imagine it's just another operator over Are you interested in attempting a pull request for this issue? |
|
@raquelxmoss has pointed out that it might be more straightforward to generate SVGs. We're going to have a go at this later on today. |
|
From @real34 on February 13, 2017 12:23 Great! Thanks for your feedback. I might not be able to work on it really soon as I already have a lot on my plate. Feel free to try things and I'll keep you updated when I will find the time for it (I may try during a few lunch breaks, but I still have a lot to learn to be efficient on this) |
|
From @raquelxmoss on February 13, 2017 19:11 @real34 We've made a start on this and have been progressing pretty well. Hopefully we'll have a PR up this week if all goes well |
|
From @staltz on February 14, 2017 20:12
Yeah, I'm the one who made those painter.js etc, and in hindsight, I'm not sure why didn't I choose SVG! :D |
From @real34 on February 11, 2017 10:11
First thank you for this great driver!
It would be great to have diagrams exported as images (seehttps://github.com/ReactiveX/rxjs/blob/master/doc/writing-marble-tests.md#generating-png-marble-diagrams-from-tests) for several reasons:
Do you think this could be part of the responsibility of this project?
From what I saw, it seems that it could be achieved easily by reusing https://github.com/ReactiveX/rxjs/tree/31dfc7324bf51b98df6678f072b7a3bd4c0b5888/spec/helpers/tests2png however I have not much experience with other reactive libraries than rxjs and don't know it it would be difficult to port it with adapters for most and xstream.
Copied from original issue: cyclejs/time#11