Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMap Cloudflare ttl=1 to 300 #210
Open
Conversation
This was referenced Feb 24, 2018
OrRosenblatt
commented
Aug 15, 2018
•
|
Why not change to ? It will keep default behavior of Cloudflare API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ross commentedFeb 24, 2018
•
edited
This will map the Cloudflare ttl of 1 to 300s which based on this support thread is the behavior users would be getting there. The result of this will be that automatic ttl things dumped from CF would have 300s ttls in the resulting output which would once synced to CF and other places result in matching/preserving behaviors. It won't change anything that's already 1 in CF unless the record otherwise is being modified.
I think this is our best option for handling the automatic TTLs with the mindset of trying to get multiple providers to behavior the same way from a single config (octoDNS's mindset.)
/cc Fixes #202
/cc Replaces #204
/cc @vanbroup @ad-m for thoughts