Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Lexicon provider #546
Closed
Add Lexicon provider #546
Conversation
Handle updates of multi value records better.
|
I put this one into third party library instead. It can be found here: https://github.com/doddo/octodns-lexicon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
doddo commentedMay 17, 2020
Add Lexicon provider per #534 which could potentially solve gandi
support #476, GoDaddy support #365 and maybe Aliyun(WanWang) #386 to name a few
by using this "wrapper" for Lexicon (which has support for these)
All record types possible are not added yet, and although test coverage is 100%, I have yet to assert enough data is correct between the various transformations, but I figure I'd open this PR up for review, and will complete the rest meanwhile, as they'd not introduce any significant changes.
Another caveat is that I have only tried this one with the gandi Lexicon provider.