Skip to content

/ vscode_deno

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite deno finder #55

Merged
merged 1 commit into from May 22, 2020
Merged

rewrite deno finder #55

merged 1 commit into from May 22, 2020

Conversation

@justjavac
Copy link
Contributor

@justjavac justjavac commented May 22, 2020

Use the full path of the deno executable file to run deno types... etc.

fixes #19
@justjavac
rewrite deno finder
Verified
This commit was signed with a verified signature.
justjavac 迷渡
GPG key ID: E620EFD1C4B4AF1B Learn about signing commits
Loading status checks…
4bc47c7 
Signed-off-by: 迷渡 <justjavac@gmail.com>
@ry
ry approved these changes May 22, 2020
View changes
Copy link
Member

@ry ry left a comment

LGTM
@ry ry merged commit 76f84ca into denoland:master May 22, 2020
3 checks passed
3 checks passed
test in ubuntu-latest
Details
test in macOS-latest
Details
test in windows-latest
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Failed to Detect Deno
2 participants
@justjavac @ry
You can’t perform that action at this time.