Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Z-function algorithm implementation #2067

Open
wants to merge 3 commits into
base: master
from
Open

Add Z-function algorithm implementation #2067

wants to merge 3 commits into from

Conversation

@nikalosa
Copy link

nikalosa commented Jun 3, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
nikalosa added 2 commits Jun 3, 2020
@nikalosa
Add Z-function algorithm implementation
Loading status checks…
fb97daa
@nikalosa
Spelling correction
Loading status checks…
d2f4f05
@cclauss
cclauss reviewed Jun 3, 2020
View changes
strings/z_function.py Outdated
@@ -0,0 +1,61 @@
"""
https://cp-algorithms.com/string/z-function.html#:~:text=The%20Z%2Dfunction%20for%20this,Note.

This comment has been minimized.

Sign in to view
Copy link
@cclauss

cclauss Jun 3, 2020

Member
Suggested change
https://cp-algorithms.com/string/z-function.html#:~:text=The%20Z%2Dfunction%20for%20this,Note.
https://cp-algorithms.com/string/z-function.html

This comment has been minimized.

Sign in to view
Copy link
@nikalosa

nikalosa Jun 3, 2020

Author

Thanks for the review, I will change it
@cclauss
Copy link
Member

cclauss commented Jun 3, 2020

One Python file per pull request please.
@nikalosa
Copy link
Author

nikalosa commented Jun 3, 2020

One Python file per pull request please.

Sure, it was mistake. I'm going to make another PR for that file and accidentally I pushed here.
@nikalosa
Reference url correction
Loading status checks…
9d70fb8
@nikalosa nikalosa force-pushed the nikalosa:z-function branch from 601de32 to 9d70fb8 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@nikalosa @cclauss
You can’t perform that action at this time.