Corrections to errors in the existing files #795

kvedala · 2020-05-26T03:15:07Z

Description of Change

There are indeed a lot of corrections because of the errors that already exist in the repository.
This is a major effort to fix all the existing errors in the repository:

wrongfully named
non-compiling codes
cpplint incompatible codes

There are a lot of files that changed and I already have a few auto-check tools that verify the CPPLINT and also compilation on linux, Windows and Mac operating systems. This can be checked here: https://github.com/kvedala/C-Plus-Plus/tree/cmake

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
Sort by alphabetical order
I acknowledge that all my contributions will be made under the project's license.

Notes:


        cherry pick changes from "cmake branch"


        syntax correction

(cherry picked from commit 260ba8d)


        file rename to standards

(cherry picked from commit 412d3ff)


        ignore build directory

(cherry picked from commit 0e3a57a)


        major corrections in the files - bad CPPLINT and non-compilable codes


        updating DIRECTORY.md


        non compiling and illegible code removed


        files renamed to standard - without spaces and made CPPLINT compatible


        updating DIRECTORY.md


        filenames and namespace fixes


        Merge branch 'major-corrections-to-files' of github.com:kvedala/C-Plu…

…s-Plus into major-corrections-to-files * 'major-corrections-to-files' of github.com:kvedala/C-Plus-Plus: updating DIRECTORY.md


        updating DIRECTORY.md


        fix inttypes


        made functions static to files

*BUG* in CPP lint github action


        updating DIRECTORY.md

kvedala · 2020-05-26T03:37:56Z

@cclauss seems like the cpplint check tool is incorrectly linking the files: link
Instead of compiling and linking each file separately, it is incorrectly linking them all together. This is leading to duplicate references to functions like main

subprocess.CalledProcessError: Command '['g++', 'computer_oriented_statistical_methods/Gaussian_elimination.cpp', 'computer_oriented_statistical_methods/bisection_method.cpp', 'computer_oriented_statistical_methods/false-position.cpp', 'computer_oriented_statistical_methods/newton_raphson_method.cpp', 'computer_oriented_statistical_methods/secant_method.cpp', 'computer_oriented_statistical_methods/successive_approximation.cpp', 'math/fibonacci.cpp', 'math/prime_factorization.cpp', 'others/GCD_of_n_numbers.cpp', 'others/fibonacci_fast.cpp', 'others/matrix_exponentiation.cpp', 'others/pascal_triangle.cpp', 'sorting/shell_sort2.cpp']' returned non-zero exit status 1.


        fix cpp_lint bug


        fixed more filenames


        updating DIRECTORY.md


        remove dash from filename


        updating DIRECTORY.md

.github/workflows/cpplint_modified_files.yml

.gitignore

cclauss · 2020-05-26T07:14:30Z

Too many files to review on one pull request. Can someone else please review?


        newline character at EOF of gitignore

(cherry picked from commit 614ea8e)


        `rand_r` is non-portable and obsolete

(cherry picked from commit 0ad756f)


        improved documentation

(cherry picked from commit 139964d)


        cin accepts only one variable at a time & fixed cpplint

(cherry picked from commit 2def9ab)


        file rename

(cherry picked from commit d6d328c)


        fixed lint

(cherry picked from commit fb3a809)


        fixed windows build error

(cherry picked from commit 4b25222)


        removed in-favor of chronos library of c++11

(cherry picked from commit 899be6a)


        fixed dynamic array

(cherry picked from commit dd20bf9)


        MSVC does not know cstring-use string-for toString

(cherry picked from commit fe9d2b9)


        updating DIRECTORY.md


        fix CPPLINT in sorting folder

(cherry picked from commit 7efa52e)


        sorting fixes for MSVC and CPPLINT

(cherry picked from commit 76a5f57)


        cpplint and msvc fixes for - sorting

(cherry picked from commit 0d8e015)


        fix dynamic array

(cherry picked from commit 717f5c8)


        fix dynamic array issues in sorting folder

(cherry picked from commit 01b69fc)


        cpplint issues fixed in sorting folder

(cherry picked from commit 35c5376)


        updating DIRECTORY.md


        added deleted files back - not really needed but there is a redundant…

… github action that required it

kvedala · 2020-05-26T23:49:23Z

Too many files to review on one pull request. Can someone else please review?

There are a lot of existing errors in the repository that need to be fixed.
This is a major initiative to normalizaing these corrections 😓


        Merge branch 'master' into major-corrections-to-files


        fix buzz number


        fixed CPPLINT + added method 2


        fixed decimal to hex


        fixed decimal to roman

kvedala · 2020-05-30T12:07:50Z

Step 2 for #805

cpplint fixes for some files
@ayaankhan98 @cclauss

Check box to indicate review completed

kvedala · 2020-05-30T12:08:52Z

part of #805
@cclauss @ayaankhan98

Check box to indicate review completed

kvedala · 2020-05-30T12:10:26Z

step for #805

more cpplint corrections
filenames normalized
@cclauss @ayaankhan98

Check box to indicate review completed

kvedala · 2020-05-30T12:12:58Z

step for #805

filenames normalized
cpplint corrections
@cclauss @ayaankhan98

Check box to indicate review completed

kvedala and others added 15 commits May 26, 2020

cherry pick changes from "cmake branch"

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

a166327

syntax correction

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

8207c77

(cherry picked from commit 260ba8d)

file rename to standards

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

b36322c

(cherry picked from commit 412d3ff)

ignore build directory

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

1e5b9f8

(cherry picked from commit 0e3a57a)

major corrections in the files - bad CPPLINT and non-compilable codes

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

baea3b0

updating DIRECTORY.md

ef24ae3

non compiling and illegible code removed

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

4e8a2f7

files renamed to standard - without spaces and made CPPLINT compatible

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

120fe06

updating DIRECTORY.md

Loading status checks…

15d481f

filenames and namespace fixes

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

82dab75

updating DIRECTORY.md

4c7685f

fix inttypes

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

Loading status checks…

c93f3ef

made functions static to files

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

Loading status checks…

b9bb6ca

*BUG* in CPP lint github action

updating DIRECTORY.md

2e2f9c2

kvedala and others added 5 commits May 26, 2020

fix cpp_lint bug

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

Loading status checks…

22b375c

fixed more filenames

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

Loading status checks…

dddcbee

updating DIRECTORY.md

9d64ff0

remove dash from filename

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

Loading status checks…

ecffb77

updating DIRECTORY.md

Loading status checks…

f28099d

cclauss reviewed May 26, 2020

View changes

.github/workflows/cpplint_modified_files.yml Show resolved Hide resolved

cclauss reviewed May 26, 2020

View changes

.github/workflows/cpplint_modified_files.yml Show resolved Hide resolved

cclauss reviewed May 26, 2020

View changes

.gitignore Outdated Show resolved Hide resolved

kvedala force-pushed the kvedala:major-corrections-to-files branch from fe9d2b9 to f28099d May 26, 2020

kvedala added 4 commits May 26, 2020

newline character at EOF of gitignore

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

a6319c5

(cherry picked from commit 614ea8e)

`rand_r` is non-portable and obsolete

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

36b4d59

(cherry picked from commit 0ad756f)

improved documentation

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

05ec7be

(cherry picked from commit 139964d)

cin accepts only one variable at a time & fixed cpplint

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

5fddd6c

(cherry picked from commit 2def9ab)

kvedala and others added 7 commits May 26, 2020

file rename

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

5f8b270

(cherry picked from commit d6d328c)

fixed lint

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

59be834

(cherry picked from commit fb3a809)

fixed windows build error

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

4847329

(cherry picked from commit 4b25222)

removed in-favor of chronos library of c++11

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

8cb310a

(cherry picked from commit 899be6a)

fixed dynamic array

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

64c8bf3

(cherry picked from commit dd20bf9)

MSVC does not know cstring-use string-for toString

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

Loading status checks…

a15b5c5

(cherry picked from commit fe9d2b9)

updating DIRECTORY.md

cfe9142

kvedala changed the title ~~Major corrections to files~~ Major corrections to errors in the existing files May 26, 2020

kvedala changed the title ~~Major corrections to errors in the existing files~~ Corrections to errors in the existing files May 26, 2020

kvedala and others added 8 commits May 26, 2020

fix CPPLINT in sorting folder

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

e4084e7

(cherry picked from commit 7efa52e)

sorting fixes for MSVC and CPPLINT

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

887bff8

(cherry picked from commit 76a5f57)

cpplint and msvc fixes for - sorting

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

77e781f

(cherry picked from commit 0d8e015)

fix dynamic array

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

09f0733

(cherry picked from commit 717f5c8)

fix dynamic array issues in sorting folder

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

231c99f

(cherry picked from commit 01b69fc)

cpplint issues fixed in sorting folder

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

Loading status checks…

d3acc55

(cherry picked from commit 35c5376)

updating DIRECTORY.md

6e6f92e

added deleted files back - not really needed but there is a redundant…

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

Loading status checks…

07ebe71

… github action that required it

kvedala mentioned this pull request May 26, 2020

Large numbers library #793

Open

7 of 8 tasks complete

kvedala added 5 commits May 27, 2020

Merge branch 'master' into major-corrections-to-files

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

3b07bc1

fix buzz number

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

e963ba4

fixed CPPLINT + added method 2

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

e7632d1

fixed decimal to hex

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

7e875ba

fixed decimal to roman

Verified

This commit was signed with a verified signature.

kvedala Krishna Vedala

GPG key ID: BA19ACF8FC8792F7 Learn about signing commits

Loading status checks…

a8bdbbd

kvedala mentioned this pull request May 29, 2020

Major rework to improve code quality and add automation checks #805

Open

8 of 8 tasks complete

cclauss mentioned this pull request May 30, 2020

Should this repo lint C++ code with clang-tidy or cpplint? #808

Open

TheAlgorithms / C-Plus-Plus

Corrections to errors in the existing files #795

Corrections to errors in the existing files #795

kvedala commented May 26, 2020 •

edited

kvedala commented May 26, 2020 •

edited

cclauss commented May 26, 2020

kvedala commented May 26, 2020 •

edited

This comment has been minimized.

kvedala commented on `baea3b0` May 30, 2020 •

edited

This comment has been minimized.

kvedala commented on `4e8a2f7` May 30, 2020 •

edited

This comment has been minimized.

kvedala commented on `120fe06` May 30, 2020 •

edited

This comment has been minimized.

kvedala commented on `b9bb6ca` May 30, 2020 •

edited

TheAlgorithms / C-Plus-Plus

Join GitHub today

Corrections to errors in the existing files #795

Corrections to errors in the existing files #795

Conversation

kvedala commented May 26, 2020 • edited

Description of Change

Checklist

kvedala commented May 26, 2020 • edited

cclauss commented May 26, 2020

kvedala commented May 26, 2020 • edited

This comment has been minimized.

kvedala commented on baea3b0 May 30, 2020 • edited

Step 2 for #805

This comment has been minimized.

kvedala commented on 4e8a2f7 May 30, 2020 • edited

This comment has been minimized.

kvedala commented on 120fe06 May 30, 2020 • edited

step for #805

This comment has been minimized.

kvedala commented on b9bb6ca May 30, 2020 • edited

step for #805

kvedala commented May 26, 2020 •

edited

kvedala commented May 26, 2020 •

edited

kvedala commented May 26, 2020 •

edited

kvedala commented on `baea3b0` May 30, 2020 •

edited

kvedala commented on `4e8a2f7` May 30, 2020 •

edited

kvedala commented on `120fe06` May 30, 2020 •

edited

kvedala commented on `b9bb6ca` May 30, 2020 •

edited