Skip to content

/ plugins

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lighthouse plugin #88

Merged
merged 2 commits into from Jun 11, 2020
Merged

feat: add lighthouse plugin #88

merged 2 commits into from Jun 11, 2020

Conversation

@erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Jun 10, 2020 •
edited

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Have you completed the following?

Test plan
Deploy log (scroll to the end):
https://app.netlify.com/sites/elastic-easley-4ab11f/deploys/5ee10492a9297824743c7210
@erezrokah
feat: add lighthouse plugin
Verified
This commit was signed with a verified signature.
erezrokah Erez Rokah
GPG key ID: B51CA2E23622ABB2 Learn about signing commits
Loading status checks…
b20876f
@github-actions
Copy link

@github-actions github-actions bot commented Jun 10, 2020 •
edited

Added Packages
@erezrokah erezrokah requested a review from ehmicky Jun 10, 2020
@ehmicky
ehmicky approved these changes Jun 10, 2020
View changes
Copy link
Contributor

@ehmicky ehmicky left a comment

This is awesome! 🎉

Few minor things (not blockers):

  • The package.json repository and bugs fields are printed in build logs when the plugin fails, so it might be better to define them
  • In here, the utils.build.failBuild() utility can take an error optional option (utils.build.failBuild(message, { error })). This allows keeping the original error.stack instead of only the error.message.
This was referenced Jun 11, 2020
Closed
Closed
@erezrokah
chore: update to version 1.0.1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e2003e1
@erezrokah
Copy link
Contributor Author

@erezrokah erezrokah commented Jun 11, 2020

Few minor things (not blockers):

  • The package.json repository and bugs fields are printed in build logs when the plugin fails, so it might be better to define them
  • In here, the utils.build.failBuild() utility can take an error optional option (utils.build.failBuild(message, { error })). This allows keeping the original error.stack instead of only the error.message.

Published a new version with the fixes
@ehmicky ehmicky merged commit 77c0019 into master Jun 11, 2020
2 checks passed
2 checks passed
build (ubuntu-latest, 13.x)
Details
Required PR Labels Has required label - type: feature
@ehmicky ehmicky deleted the feat/add_lighthouse_plugin branch Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky

Assignees
No one assigned
Labels
feat/build-plugins type: feature
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@erezrokah @ehmicky
You can’t perform that action at this time.