Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34605, libregrtest: Avoid master/slave terms #9099

Merged
merged 1 commit into from Sep 7, 2018

Conversation

@vstinner
Copy link
Member

vstinner commented Sep 7, 2018

  • Rename --slaveargs to --worker-args
  • Rename run_tests_slave() to run_tests_worker()

https://bugs.python.org/issue34605

* Rename --slaveargs to --worker-args
* Rename run_tests_slave() to run_tests_worker()
@vstinner vstinner added the skip news label Sep 7, 2018
@vstinner vstinner merged commit 012f5b9 into python:master Sep 7, 2018
9 checks passed
9 checks passed
Linux-PR #Linux-PR_20180907.20 succeeded
Details
Linux-PR-Coverage #Linux-PR-Coverage_20180907.16 succeeded
Details
Windows-PR #Windows-PR_20180907.20 succeeded
Details
bedevere/issue-number Issue number 34605 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docs #docs_20180907.20 succeeded
Details
macOS-PR #macOS-PR_20180907.20 succeeded
Details
@vstinner vstinner deleted the vstinner:regrtest_master_slave branch Sep 7, 2018
lisroach added a commit to lisroach/cpython that referenced this pull request Sep 12, 2018
…-9099)

Rename also run_tests_slave() to run_tests_worker().
@rsaleri

This comment was marked as off-topic.

@and3rson

This comment was marked as off-topic.

@NiKiZe

This comment was marked as off-topic.

@Marcon

This comment was marked as disruptive content.

@python python locked and limited conversation to collaborators Sep 13, 2018
@python python deleted a comment from pkarolyi Sep 13, 2018
@python python deleted a comment from babadoctor Sep 13, 2018
@python python deleted a comment from rsaleri Sep 13, 2018
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Sep 14, 2018

This one LGTM. This is our internal API, and there are no any relations with existing common terminology. I always wondered why such bizarre name was used here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.