Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upopenURL(_:) is deprecated #7448
Comments
|
Although this is not actually a bug (yet) I will mark it as one so we that the issue can be prioritized. Marking as a |
|
@NickIliev I'm willing to contribute here, but I'm not sure how to proceed regarding my comment on the API implications:
The current NS API passes on the success boolean for the call to openURL, however Android's call is still synchronous. Making the NS API asynchronous for either or (preferably) both Android & iOS would be a breaking change. In the meantime I'll review the contributing document you link to. Thanks for the quick response! |
Is your feature request related to a problem? Please describe.
UIApplication#openURL(_:)is deprecated since iOS 10. It appears to be available still in iOS 12, but it will eventually need to be replaced and I could not find an issue for this.This is used by
tns-core-modules/utils'sopenUrlhere.Describe the solution you'd like
Switch to the Apple recommended
UIApplication#open(_:options:completionHandler:)Describe alternatives you've considered
open(_:options:completionHandler:)directly (not necessary yet / with current SDKs)Additional context
I have not downloaded the headers for iOS 13 developer preview to see if
openURL(_:)unavailable in the next version, but I assume it will be since Apple's own documentation still references it inUIApplication's overview.Also, there are implications that may have to surface up to the
tns-core-modulesAPI since the deprecatedopenURLis synchronous, but the replacement is asynchronous.Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.