Prevent BigInteger serialization errors in term queries #57987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a numeric value in e.g. a `term` query doesn't fit into a long, it curerently gets parsed to a BigInteger object, that the various term query builders store untouched. This leads to serialization errors when these queries are sent across the wire. Instead we can convert to a string representation early on, since that is what we store e.g. when indexing big integers into `keyword` fields anyway. Closes elastic#57917
cbuescher
added
>bug
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
|
@elasticmachine update branch |
|
@javanna would you mind taking a look if you have time? I thought this might be down your alley. |
cbuescher
pushed a commit
that referenced
this pull request
Jun 18, 2020
When a numeric value in e.g. a `term` query doesn't fit into a long, it curerently gets parsed to a BigInteger object, that the various term query builders store untouched. This leads to serialization errors when these queries are sent across the wire. Instead we can convert to a string representation early on, since that is what we store e.g. when indexing big integers into `keyword` fields anyway. Closes #57917
cbuescher
pushed a commit
that referenced
this pull request
Jun 18, 2020
When a numeric value in e.g. a `term` query doesn't fit into a long, it curerently gets parsed to a BigInteger object, that the various term query builders store untouched. This leads to serialization errors when these queries are sent across the wire. Instead we can convert to a string representation early on, since that is what we store e.g. when indexing big integers into `keyword` fields anyway. Closes #57917
cbuescher
pushed a commit
that referenced
this pull request
Jun 23, 2020
When a numeric value in e.g. a `term` query doesn't fit into a long, it curerently gets parsed to a BigInteger object, that the various term query builders store untouched. This leads to serialization errors when these queries are sent across the wire. Instead we can convert to a string representation early on, since that is what we store e.g. when indexing big integers into `keyword` fields anyway. Closes #57917
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a numeric value in e.g. a
termquery doesn't fit into a long, itcurerently gets parsed to a BigInteger object, that the various term query
builders store untouched. This leads to serialization errors when these queries
are sent across the wire. Instead we can convert to a string representation
early on, since that is what we store e.g. when indexing big integers into
keywordfields anyway.Closes #57917