Skip to content

/ grape

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Headers section in README seems misleading #1901

Open
FunkyloverOne opened this issue Aug 21, 2019 · 3 comments
Open

Request Headers section in README seems misleading #1901

FunkyloverOne opened this issue Aug 21, 2019 · 3 comments
Labels
bug?

Comments

@FunkyloverOne
Copy link

@FunkyloverOne FunkyloverOne commented Aug 21, 2019 •
edited

Perhaps it is related to #1770.

So the README says that an example below will be normalized:

curl -H "secret_PassWord: swordfish" ...

But actually - it won't. If header name contains an underscore - in env it will remain as is and without HTTP_ prefix, and it won't appear in headers helper at all.
@dblock dblock added the bug? label Aug 21, 2019
@dblock
Copy link
Member

@dblock dblock commented Aug 21, 2019 •
edited

Please fix? Do show us some repro output too.
@myxoh myxoh mentioned this issue Oct 30, 2019
Closed
@myxoh
Copy link
Member

@myxoh myxoh commented Oct 30, 2019

I am adding some integration specs, not sure whether we want to merge them, but they do demonstrate a different behaviour.

Test here: #1927
@FunkyloverOne
Copy link
Author

@FunkyloverOne FunkyloverOne commented Dec 4, 2019

Interesting, I have such issues in a Rails app, with Grape API mounted in routes.rb. And code like env.to_json does not even work there, it ends up with an infinite loop.

Perhaps that's some new activesupport-5.2.4 bug though.

However, I can try env.keys instead, and my initial issue is still reproducing. Perhaps there's something else is wrong with the project. I gotta dive deeper into it to figure it out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug?
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@dblock @myxoh @FunkyloverOne
You can’t perform that action at this time.