Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
General code optimizations. #693
Conversation
|
Bruno Feliciano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
There's a lot of |
|
I have made a new pull, removing unnecessary changes. Please review. |
| { | ||
| autofacRootResolver.ValidateRegistrations(); | ||
| } | ||
| using (var autofacRootResolver = new AutofacRootResolver(container)) |
FinalFortune
Oct 11, 2019
Assume the container gets disposed with it, not sure why there's a return new AutofacRootResolver(container);.
Should remove the using and have return autofacRootResolver
|
Still failing tests |
No description provided.