Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java : add fastjson detection. Improve RemoteFlowSource class, support SpringMvc #119

Open
haby0 opened this issue Jun 10, 2020 · 2 comments
Open
Labels

Comments

@haby0
Copy link

@haby0 haby0 commented Jun 10, 2020

CVE

There is no CVE for this.

Report

This query adds Fastjson deserialization sinks.

JSON.parseObject(cmd);
JSON.parse(cmd);

It has been added to CWE-502. I found that RemoteFlowSource cannot be supported in the test: (1) SpringMVC directly submits parameters; (2) SpringMVC does routing access through Mapping annotations, and the original verification does not have this logic. I Some additions have been made here.

please check:

codeql\java\ql\src\semmle\code\java\frameworks\SpringMVC.qll

codeql\java\ql\src\semmle\code\java\dataflow\FlowSources.qll SpringMVC class

codeql\java\ql\src\semmle\code\java\security\UnsafeDeserialization.qll

codeql\java\ql\src\Security\CWE\CWE-502

Link to the PR:github/codeql#3665

@haby0 haby0 added the All For One label Jun 10, 2020
@haby0
Copy link
Author

@haby0 haby0 commented Jun 10, 2020

Some problems occurred on my side, new prs were added, the problem is the same.
Link to the PR:github/codeql#3674

@ghsecuritylab
Copy link
Collaborator

@ghsecuritylab ghsecuritylab commented Aug 20, 2020

Your submission is now in status SecLab review.

For information, the evaluation workflow is the following:
CodeQL initial assessment > SecLab review > CodeQL review > SecLab finalize > Pay > Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.