feat: Flexible Error/Exception handling #5929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
MartoYankov
approved these changes
Jun 13, 2018
| } | ||
|
|
||
| // before each | ||
| export function tearDown() { |
There was a problem hiding this comment.
Technically, this is executed after each test. There is a setUp() function for before each.
There was a problem hiding this comment.
yup - I want to cache the original ErrorHandler once and clean-up after each test to make sure the test does not leak side effects
tests/app/trace/trace-error-tests.ts
Outdated
| setErrorHandler({ | ||
| handlerError(error) { | ||
| called = true; | ||
| TKUnit.assert(error instanceof Error, "trace.error() wrap string in error") |
There was a problem hiding this comment.
Even if it's fine in this case, I think it's dangerous to use asserts in callbacks. It's better to cache the value and assert it after the assertion of the called variable. In cases where the callbacks are async asserting in them breaks the tests.
tns-core-modules/trace/trace.d.ts
Outdated
| @@ -63,6 +63,11 @@ export function isCategorySet(category: string): boolean; | |||
| */ | |||
| export function write(message: any, category: string, type?: number); | |||
|
|
|||
| /** | |||
| * Passes an error ot the registered ErrorHandler | |||
vchimev
approved these changes
Jun 18, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #5914