Skip to content

/ react-native

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security issues with rnc cli by bumping version #29072

Open
wants to merge 1 commit into
base: master
from
Open

Fix security issues with rnc cli by bumping version #29072

wants to merge 1 commit into from

Conversation

@alexbrazier
Copy link

alexbrazier commented Jun 5, 2020 •
edited

Summary

Fix security issue with logkitty - used by cli-android package
react-native-community/cli#1158

Changelog

[General] [Security] - Bump package version of cli packages to fix security vulnerability
@alexbrazier
Fix security issues with rnc cli by bumping version
Loading status checks…
08c472c
@alexbrazier alexbrazier requested review from cpojer and hramos as code owners Jun 5, 2020
@pull-bot
Copy link

pull-bot commented Jun 5, 2020

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08c472c

@cpojer
cpojer approved these changes Jun 5, 2020
View changes
Copy link
Contributor

cpojer left a comment

👍
@facebook-github-bot
facebook-github-bot reviewed Jun 5, 2020
View changes
Copy link

facebook-github-bot left a comment

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@analysis-bot
Copy link

analysis-bot commented Jun 5, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,759,129 0
android hermes armeabi-v7a 6,421,816 0
android hermes x86 7,145,377 0
android hermes x86_64 7,035,349 0
android jsc arm64-v8a 8,933,023 0
android jsc armeabi-v7a 8,588,081 0
android jsc x86 8,762,378 0
android jsc x86_64 9,337,999 0

Base commit: 8821d27
@analysis-bot
Copy link

analysis-bot commented Jun 5, 2020 •
edited

Platform Engine Arch Size (bytes) Diff
ios - universal 829,440 0

Base commit: 8821d27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot

@cpojer cpojer

@hramos hramos

Assignees
No one assigned
Labels
CLA Signed Type: Security
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@alexbrazier @pull-bot @analysis-bot @cpojer @facebook-github-bot @react-native-bot
You can’t perform that action at this time.