Skip to content

/ sheetjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1087 Add File Separator to ParsingOptions for DSV files #1765

Open
wants to merge 5 commits into
base: master
from
Open

#1087 Add File Separator to ParsingOptions for DSV files #1765

wants to merge 5 commits into from

Conversation

@louisjrdev
Copy link

@louisjrdev louisjrdev commented Feb 20, 2020

No description provided.

Louis Jackson-Rees added 3 commits Feb 20, 2020
Louis Jackson-Rees
Add file separator to config options and use when reading a dsv file
de1a2a8
Louis Jackson-Rees
make the new option optional
17e82ee
Louis Jackson-Rees
Add build output
Loading status checks…
dc24b6c
@louisjrdev
Copy link
Author

@louisjrdev louisjrdev commented Feb 20, 2020

#1087 This is a PR with the change @SheetJSDev mentioned in this issue
@louisjrdev louisjrdev requested a review from SheetJSDev Feb 21, 2020
@louisjrdev
Copy link
Author

@louisjrdev louisjrdev commented Jun 5, 2020

@SheetJSDev when will this get merged?
@reviewher reviewher requested review from garrettluu and removed request for SheetJSDev Jun 18, 2020
@garrettluu
garrettluu suggested changes Jun 18, 2020
View changes
Copy link
Contributor

@garrettluu garrettluu left a comment

Changes look good to me! But please squash your commits into one using git rebase, we don't want too many commits cluttering up the commit history.
Louis Jackson-Rees
Update do that it will parse as DSV if a non-comma seperated FS is de…
0f2844b 
…tected
@louisjrdev
Copy link
Author

@louisjrdev louisjrdev commented Jun 30, 2020 •
edited

@garrettluu I have just seen a potential issue with this before squashing and I have made updates to solve, just that it needed a check for the custom separator to ensure if one is provided it is processed as a dsv file. Can you confirm you are happy with this extra change and I will squash the commits and rebase
@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 0786b99 to 3b589f0 Aug 12, 2020
@louisjrdev
Merge branch 'master' into feature1087_addFileSeparator
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b082c46
@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 4254ed4 to eec93b0 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettluu garrettluu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@louisjrdev @garrettluu
You can’t perform that action at this time.