messages: improve concrete_only_{call,assign} #8832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment in the code near where these functions are called was more descriptive than the message itsnelf
TH3CHARLie
reviewed
May 16, 2020
There was a problem hiding this comment.
Personally I think it's great to have better messages. To pass tests, you need to locate the error message"Can only assign concrete classes to a variable of type {}: in the test suite and add the additional part accordingly. cc @ethanhs
| @@ -1222,11 +1222,16 @@ def bad_proto_variance(self, actual: int, tvar_name: str, expected: int, | |||
| self.fail(msg, context) | |||
|
|
|||
| def concrete_only_assign(self, typ: Type, context: Context) -> None: | |||
| self.fail("Can only assign concrete classes to a variable of type {}" | |||
| self.fail("Can only assign concrete classes to a variable of type {}: " | |||
| "Only non-abstract non-protocol classes can be assigned to " | |||
There was a problem hiding this comment.
I think this may better with self.note to denote the hint.
|
Thanks for your PR! Could you please merge the current master and fix the test errors? |
|
Closing as stale. If someone wants to pick this up, I liked the note suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the code near where these functions are called was more descriptive than the message itsnelf