Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed error in factorial.py #1888

Open
wants to merge 1 commit into
base: master
from
Open

fixed error in factorial.py #1888

wants to merge 1 commit into from

Conversation

@SandersLin
Copy link
Contributor

SandersLin commented Apr 17, 2020 •
edited

Describe your change:

factorial(11) returns index out of range. To implement memoization an auxiliary function is required.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@SandersLin
Update factorial.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
49654da
@us3rnotfound
us3rnotfound suggested changes May 13, 2020
View changes
Copy link

us3rnotfound left a comment

Recommend making factorial_aux a private function since no outside entity need use it.

Recommend putting the debug statements back in showing where to print result for debugging, although I noticed debugging it in that fashion causes docttest to print out a lot of example failed blocks.

Otherwise I think this change is good and it makes sense.
@cclauss
cclauss reviewed May 13, 2020
View changes
dynamic_programming/factorial.py

def factorial_aux(num, result):

if num == 0 or num == 1:

This comment has been minimized.

Sign in to view
Copy link
@cclauss

cclauss May 13, 2020

Member
Suggested change
if num == 0 or num == 1:
if num in (0, 1):

This comment has been minimized.

Sign in to view
Copy link
@swapnanildutta

swapnanildutta Jun 1, 2020

Contributor

This makes more sense.
@swapnanildutta
swapnanildutta approved these changes Jun 1, 2020
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@swapnanildutta swapnanildutta

@us3rnotfound us3rnotfound

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@SandersLin @cclauss @us3rnotfound @swapnanildutta
You can’t perform that action at this time.