Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create merge_sort_v3.py #2063

Open
wants to merge 1 commit into
base: master
from
Open

Create merge_sort_v3.py #2063

wants to merge 1 commit into from

Conversation

@maahi07m
Copy link

maahi07m commented Jun 2, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@maahi07m
Create merge_sort_v3.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
70acadd
@cclauss
cclauss reviewed Jun 2, 2020
View changes
sorts/merge_sort_v3.py
@@ -0,0 +1,49 @@
# Python program for implementation of MergeSort
def mergeSort(arr):

This comment has been minimized.

Sign in to view
Copy link
@cclauss

cclauss Jun 2, 2020

Member

No type hints or doc tests... See CONTRIBUTING.md

This comment has been minimized.

Sign in to view
Copy link
@maahi07m

maahi07m Jun 5, 2020

Author

yeah i will add that
@jntushar
jntushar suggested changes Jun 3, 2020
View changes
sorts/merge_sort_v3.py
if __name__ == '__main__':
arr = [12, 11, 13, 5, 6, 7]
print ("Given array is", end="\n")
printList(arr)

This comment has been minimized.

Sign in to view
Copy link
@jntushar

jntushar Jun 3, 2020

You can directly print list using print(arr)

This comment has been minimized.

Sign in to view
Copy link
@jntushar

jntushar Jun 3, 2020

instead of creating a separate function

This comment has been minimized.

Sign in to view
Copy link
@maahi07m

maahi07m Jun 5, 2020

Author

yup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@jntushar jntushar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Tests are needed Type hints needs automated tests are failing
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@maahi07m @cclauss @jntushar
You can’t perform that action at this time.