This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix stop_serving in proactor loop kill all listening servers #496
Conversation
|
LGTM. @asvetlov can you also take a look? |
fafhrd91
commented
Feb 22, 2017
|
lgtm asvetlov is not very active at the moment |
|
I can merge this PR, but would you be able to re-submit it to http://github.com/python/cpython with a link to this PR? This would make merging this easier for me. |
|
Yes of course I will do it tomorrow.
Le jeu. 2 mars 2017 à 23:14, Yury Selivanov <notifications@github.com> a
écrit :
… I can merge this PR, but would you be able to re-submit it to
http://github.com/python/cpython <https://github.com/python/cpython> with
a link to this PR? This would make merging this easier for me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#496 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVFXZkNrVTmNCSK3TgLWlP-43YwozhSks5rhz8qgaJpZM4MHtGW>
.
|
Would you be able to do it sooner by any chance? 3.6.1 RC1 is going to be tagged tomorrow. |
|
PR opened: python/cpython#431 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
noplay commentedFeb 21, 2017
Current implementation of the asyncio Proactor event loop has an issue, when you stop a server it's cancel the futures of all other servers.